-
Notifications
You must be signed in to change notification settings - Fork 22
Use unique field number for custom options #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User description
PR Type
Enhancement
Description
Changed custom option field number from 50000 to 2113
Ensures unique field numbering for protobuf extensions
Aligns with protobuf best practices for custom options
Diagram Walkthrough
File Walkthrough
rpc.proto
Update ErrorMetadata extension field numbersrc/main/proto/kurrentdb/protocol/v2/rpc.proto
ErrorMetadataextension field number from 50000 to 2113